I just got an iPhone 4 and is very happy with.
I've got something weird with my S4i, which I didn't have with the 3GS. What's happening is that I can hear input from the mic in the headphones, e.g. my own voice, engine noise from the car, etc.. This wasn't the case on the 3GS.